Make the install directory configurable #3
Conversation
|
I tried adding a test, too, but apparently the YAML is invalid: I'm utterly failing to work out what the problem is, though – as best I can tell the bit it's objecting to is more-or-less identical to the similar example in "complex-test"… |
|
Ah, fixed that test problem; I was mangling my Git commands unhelpfully. |
Default to maintaining the current behaviour, but allow users of this action to change the install directory. This means it's possible, for example, to use the default-everywhere-else behaviour of installing 64-bit Cygwin to C:\cygwin64, or to ease migration from other GitHub Actions such as egor-tensin/setup-cygwin, which defaults to installing in C:\tools\cygwin.
|
Okay, that was clearly not ready to be a PR at the time I created it, given just how many times I needed to force-push to correct the test code. But the test is now working on my fork, so I think this PR is actually ready to be looked at and pulled now. |
|
Thanks! This was just me being lazy since a fixed path was all I needed for my particular application. This also needs an change to README.md to document the new parameter. |
|
Okay, removed the extraneous |
|
Thanks! |
Default to maintaining the current behaviour, but allow users of this
action to change the install directory. This means it's possible, for
example, to use the default-everywhere-else behaviour of installing
64-bit Cygwin to C:\cygwin64, or to ease migration from other GitHub
Actions such as egor-tensin/setup-cygwin, which defaults to installing
in C:\tools\cygwin.